[CVE-2023-28839] Improper neutralization of a SQL parameter in Shoppingfeed module for PrestaShop

SQL injection vulnerability found in the module “Shoppingfeed PrestaShop Plugin (Feed&Order)” (aka shoppingfeed) for PrestaShop from 1.4.0 to 1.8.2. (1.8.3 fix the issue) allow a remote attacker to gain privileges.

Summary

CVE ID: CVE-2023-28839
Published at: 2023-04-18
Advisory source: Github repository of Shoppingfeed PrestaShop Plugin
Platform: Shoppingfeed
Product: shoppingfeed
Impacted release: >1.4.0 and <=1.8.2 (1.8.3 fix the issue).
Product author: 202 ecommerce
Weakness: CWE-89
Severity: critical (9.8)

Description

From 1.4.0 to 1.8.2 (1.8.3 fix the issue), a sensitive SQL call in ShoppingfeedToken::findByToken() can be executed with a trivial http call and exploited to forge a blind SQL injection through the POST or GET submitted variable token.

CVSS base metrics

Attack vector: network
Attack complexity: low
Privilege required: none
User interaction: none
Scope: unchanged
Confidentiality: high
Integrity: high
Availability: high

Vector string: CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:H/I:H/A:H

Possible malicious usage

Technical and personal data leaks
Obtain admin access
Remove all data of the linked PrestaShop
Display sensitives tables to front-office to unlock potential admin’s ajax scripts of modules protected by token on the ecosystem

Patch

--- a/modules/shoppingfeed/classes/ShoppingfeedToken.php
+++ b/modules/shoppingfeed/classes/ShoppingfeedToken.php
@@ -138,7 +138,7 @@ public function findByToken($token)
         $query = (new DbQuery())
             ->select('*')
             ->from(self::$definition['table'])
-            ->where("content = '$token'")
+            ->where('content = "' . pSQL($token) . '"')
         ;
 
         return Db::getInstance(_PS_USE_SQL_SLAVE_)->getRow($query);

Other recommendations

It’s recommended to upgrade the module beyond 1.8.3.
To help improve the security of your PrestaShop installation, we recommend upgrading to the latest version. One of the benefits of upgrading is that it will disable the use of multiquery executions (separated by semicolons). However, please be aware that this will not protect your shop against SQL injection attacks that use the UNION clause to steal data. Additionally, it’s important to note that PrestaShop includes a function called pSQL, which includes a strip_tags function. This helps protect your shop against Stored XSS (also known as XSS T2) of Category 1. If a pSQL function is missing, it could potentially expose your project to critical Stored XSS vulnerabilities due to edge cases. Therefore, it’s crucial to ensure that all relevant functions are properly implemented and used consistently throughout your project.
Change the default database prefix ps_ by a new longer arbitrary prefix. Nevertheless, be warned that this is useless against blackhats with DBA senior skill because of a design vulnerability in DBMS
Activate OWASP 942’s rules on your WAF (Web application firewall), be warned that you will probably break your backoffice and you will need to pre-configure some bypasses against these set of rules.

Timeline

Date	Action
2022-10-14	Wargan Solutions discover the vulnerability during an audit ordered by Shoppingfeed and 202 ecommerce
2022-10-14	Publish the patch release 1.8.3
2022-10-18	Shoppingfeed send a first newsletter to invite all merchands to upgrade up to 1.9.0
2022-12-12	Shoppingfeed send a second reminder to invite all merchands to upgrade
2022-03-28	Shoppingfeed send a third reminder to invite all merchands to upgrade up to 1.9.3
2023-04-18	Publish this security advisory